Skip to content

Conversation

@borisdayma
Copy link
Contributor

@borisdayma borisdayma commented Mar 7, 2022

Datasets are saved as wandb artifacts using original file names.
However, some characters are not allowed to be used as artifact name.
This PR sanitizes the name used as wandb artifact.
It also ensures results are present even when a run is marked as succeeded.

@borisdayma borisdayma marked this pull request as ready for review March 15, 2022 16:38
@borisdayma
Copy link
Contributor Author

PR confirmed to be working by user.

@hallacy hallacy merged commit 3269db8 into openai:main Mar 28, 2022
@stainless-bot stainless-bot mentioned this pull request Nov 6, 2023
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
* feat(wandb): sanitize name

* feat(wandb): ensure results are present
karpetrosyan pushed a commit to karpetrosyan/openai-python that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants